Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Add Python 3.11 to the testing #612

Merged
merged 8 commits into from
Jan 3, 2023
Merged

Add Python 3.11 to the testing #612

merged 8 commits into from
Jan 3, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 10, 2022

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 10, 2022

Should help to test #608

@cclauss
Copy link
Contributor Author

cclauss commented Dec 11, 2022 •
edited
Loading

On Python 3.11...

Running Sphinx v1.6.2
making output directory...

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/re/_parser.py", line 841, in _parse
    raise source.error('global flags not at the start '
re.error: global flags not at the start of the expression at position 3

https://docs.python.org/3.11/whatsnew/3.11.html

In re Regular Expression Syntax, global inline flags (e.g. (?i)) can now only be used at the start of regular expressions. Using them elsewhere has been deprecated since Python 3.6. (Contributed by Serhiy Storchaka in bpo-47066.)

@cclauss
Copy link
Contributor Author

cclauss commented Jan 3, 2023

@serhiy-storchaka Your thoughts, please?

Pierre-Sassoulas
Pierre-Sassoulas previously requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this co-dependant with #608 ? One of you should probably cherry-pick the change from the other one right ?

@serhiy-storchaka
Copy link

Is the full traceback available? This can help identify the regular expression that needs to be corrected.

@sambhav
Remove docs make command from tests
7aac372 
Docs are automatically generated per pull request using RTD Oauth app. We don't need to regenerate them in github actions. This also removes the dependency on python 3.11 from docs generation.
@sambhav
Copy link
Member

sambhav commented Jan 3, 2023

The failure was happening in Sphinx. Since we have enabled read the docs PR apps, the doc generation in github actions is no longer needed. A larger term fix would involve updating the Sphinx version (from 1.6.x to 6.0)

@sambhav sambhav dismissed Pierre-Sassoulas’s stale review January 3, 2023 08:55

Will merge in python 3.11 checks first and then the tomli changes can be merged to test them appropriately.

@sambhav sambhav merged commit f4db095 into PyCQA:master Jan 3, 2023
@cclauss cclauss deleted the patch-1 branch January 3, 2023 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sambhav sambhav sambhav approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @serhiy-storchaka @sambhav @Pierre-Sassoulas